Skip to content

[dataquery] fixes oversized table head element - #11087

Open
marandmart wants to merge 1 commit into
aces:mainfrom
marandmart:dataquery_scrolling_query
Open

[dataquery] fixes oversized table head element#11087
marandmart wants to merge 1 commit into
aces:mainfrom
marandmart:dataquery_scrolling_query

Conversation

@marandmart

@marandmart marandmart commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

  • Fixes issue where field descriptions could render raw HTML inside .
  • Adds min-width to td/th and max-height to headers in the table rendering to prevent excessively tall table heads when displaying long text.

Testing instructions

  1. Create a query with fields that have raw HTML in their descriptions and very long text strings.
  2. Render the dataquery table.
  3. Verify the HTML tags are safely escaped and not rendered as active HTML.
  4. Verify the table header layout remains constrained (doesn't stretch vertically).

Link to related issue

@github-actions github-actions Bot added Language: Javascript PR or issue that update Javascript code Module: dataquery PR or issue related to (new) dataquery module labels Jul 28, 2026
@HenriRabalais

HenriRabalais commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

@adamdaudrich can you take a look at this since you created the issue?

@adamdaudrich

adamdaudrich commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

LGTM
The"real world" usecase was a project in CBIGR where field names came from the following pipeline:
redcap-->redcap2linst-->DQT.
So the problem was how their redcap was setup and how the fields got translated to linst. We used a php library function to strip html out, but still...
if you have cbig repo permission, check instrument 'abasiii_521', the static ones.

@HenriRabalais

HenriRabalais commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Ok, I'll do a code review in the coming days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@HenriRabalais HenriRabalais

Labels

Language: Javascript PR or issue that update Javascript code Module: dataquery PR or issue related to (new) dataquery module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[dataquery] scrolling query

3 participants

@marandmart @HenriRabalais @adamdaudrich